sankey hover improvements #3150
Conversation
| coerceLink('color', linkOut.value.map(function() { | ||
| return defaultLinkColor; | ||
| })); | ||
| coerceLink('color', Lib.repeat(defaultLinkColor, linkOut.value.length)); |
| @@ -21,6 +21,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout | |||
| return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); | |||
| } | |||
|
|
|||
| var hoverlabelDefault = Lib.extendDeep(layout.hoverlabel, traceIn.hoverlabel); | |||
src/traces/sankey/attributes.js
Outdated
| var colorAttrs = require('../../components/color/attributes'); | ||
| var fxAttrs = require('../../components/fx/attributes'); | ||
| var domainAttrs = require('../../plots/domain').attributes; | ||
|
|
||
| var overrideAll = require('../../plot_api/edit_types').overrideAll; | ||
|
|
||
| var attrs = module.exports = overrideAll({ | ||
| module.exports = overrideAll({ | ||
| hoverinfo: plotAttrs.hoverinfo, |
There was a problem hiding this comment.
We'll need to extend the default hoverinfo declaration
plotly.js/src/plots/attributes.js
Lines 117 to 130 in 36d9fb4
with new flags. I'm thinking 'none', 'skip' and 'all'(the default) which I think should resolve @alexcjohnson 's concern #3096 (comment)
We should probably have a special description too to explain how trace hoverinfo can propagate to the node/link hoverinfo.
There was a problem hiding this comment.
@etpinard I'm having trouble setting hoverinfo.flags to an empty array [ ]. Running Plotly.PlotSchema.get().traces.sankey.attributes.hoverinfo always return 5 flags.
The following doesn't work:
var attrs = module.exports = overrideAll({
hoverinfo: plotAttrs.hoverinfo,
...
})
attrs.hoverinfo.flags = []
The following also doesn't work:
var attrs = module.exports = overrideAll({
hoverinfo: extendFlat({}, plotAttrs.hoverinfo, {
flags: ['random']
}),
...
})
although it replaces the first array element with 'random'.
I'm confused any help/pointer would be greatly appreciated 😕
There was a problem hiding this comment.
see #3058 (comment) - it's just a problem with the schema, the modules themselves are fine.
There was a problem hiding this comment.
the modules themselves are fine.
Right, gd._fullData[0]._module.attributes.hoverinfo.flags should have the new list.
There was a problem hiding this comment.
Thank you guys for the quick reply! But won't this be an issue for the automatically generated documentation?
There was a problem hiding this comment.
and already is - feel like tackling #3058, or at least that part of it?
There was a problem hiding this comment.
That, or remove hoverinfo from the global (plots/attributes.js) trace attributes.
There was a problem hiding this comment.
@alexcjohnson I will look into #3058! I actually wanted to improve on plot.ly/javascript/reference so I guess that would be a good start for me since they're related :)
| var attrs = module.exports = overrideAll({ | ||
| module.exports = overrideAll({ | ||
| hoverinfo: extendFlat({}, plotAttrs.hoverinfo, { | ||
| flags: [], |
There was a problem hiding this comment.
Nicely done, plotAttrs.hoverinfo already has the correct extras field
plotly.js/src/plots/attributes.js
Line 121 in d5ebb50
|
Nice job @antoinerg this PR is already worthy of a 💃 I'd say tackling #3058 or #3150 (comment) will deserve a PR of its own. |
Addressing comments of @etpinard on PR #3096.
.mapcall byLib.repeathover(info|label)I also DRYed up some tests!