fix support for typed arrays in bar 'width' and 'offset' #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
commented
Oct 26, 2018
| assertArrayField(cd[1][0], 't.poffset', o); | ||
| assertPointField(cd, 'x', [ | ||
| [0.5, 1.8, 3.1], | ||
| [0.5, 1.8, 3.099] |
There was a problem hiding this comment.
Huh, took me a while to figure out where these numbers came from... surprised I had never noticed this before but it seems weird that offset sets the left edge of each bar rather than its center. Oh well, a little late to change that. Why does the second one get 3.099 instead of 3.1?
There was a problem hiding this comment.
I'm not sure.
With a regular array, we get:
[0.5, 1.7999999999999998, 3.1]
with a typed array, we get:
[0.5000000014901161, 1.8000000059604644, 3.099999988079071]
There was a problem hiding this comment.
ah ok, that's just because it's a Float32Array ie single precision, not double. But it's still closer to 3.1 than to 3.099 😏
|
💃 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3142 and a similar unlisted bug for bar
offset.cc @plotly/plotly_js