Joyplots2

[Kully]

Rebasing from this commit from original Joyplots PR #3109

[etpinard]

@plotly/plotly_js tagging this as reviewable. It's about time!

The improved algo is in bf6cfa2 which 🔪 all our concerns from #3234 (comment) (I think 😉 ).

Jasmine tests are now passing thanks to 12ff323 🎉

[etpinard]

@Kully could you take a few minutes this week to double-check my latest attempt?

[nicolaskruchten]

Let's get rid of the name "joyplot" here if possible, in favour of "ridgeplot"

[etpinard]

Ok done in c1d6e76

[etpinard]

@antoinerg this PR is a bit of a mess, but could I ask you to review it before next Tuesday (the 22nd)?

[antoinerg]

@etpinard Looks very nice!

However, I noticed that the axis range does not always update properly. For example, for the mock violin_box_multiple_widths.json, when I hide the box with width=0.6 by clicking on its name on the legend, I end up with:

As you can see, one of the violin is clipped. Is this the expected behavior?

[etpinard]

when I hide the box by clicking on its name on the legend I end up with:

Thanks. Fixed in a237252

[antoinerg]

Nice fix 👌 !

Another question, this one is about the current behavior for automatic width. We resize the violins even when the axis range isn't modified: for example, the auto trace goes from small to very large upon hiding trace witdh: 0.4:

I just want to make sure this is what we want. Maybe we should add a Jasmine test to 🔒 that down?

@etpinard let me know what you think!

[etpinard]

Maybe we should add a Jasmine test to that down?

That change in violin width comes from

plotly.js/src/traces/box/cross_trace_calc.js

Lines 73 to 74 in a237252

	var boxdv = Lib.distinctVals(pointList);
	var dPos0 = boxdv.minDiff / 2;

where we have two distinct violin position vals at first, and then just once after that restyle call.

Here's the new test: ef52b8c

[antoinerg]

Great job @etpinard ! 💃

[etpinard]

Thanks for catching the bug from #3234 (comment) @antoinerg !

[etpinard]

In brief, this PR:

• adds width to box and violin traces
• improves box/violin autorange calculations