Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3336 - don't try to makeCalcdata on visible:false traces #3343

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

etpinard
Copy link
Contributor

... in Histogram.calc loop looking for isFirstVisible traces.

cc @plotly/plotly_js - a follow-up of #3044

cc @nicolaskruchten

peek 2018-12-17 14-01

... in Histogram.calc loop looking for isFirstVisible trace
@etpinard etpinard added bug something broken status: reviewable labels Dec 17, 2018
@archmoj
Copy link
Contributor

archmoj commented Dec 17, 2018

Good fix 💃 from my corner_|.

@etpinard etpinard merged commit 431fd51 into master Dec 17, 2018
@etpinard etpinard deleted the histogram-first-visible-skip-empties branch December 17, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants