Add config options in plot schema #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which match the current "default", but will make scrollZoom:false disable zoom for all subplots!
|
... @archmoj would you mind taking a look at this one at some point this week? |
|
This one is also interesting to review. Thanks @etpinard. |
archmoj
reviewed
Jan 16, 2019
|
|
||
| queueLength: { | ||
| valType: 'integer', | ||
| min: 0, |
There was a problem hiding this comment.
It may be useful to have a max for this.
There was a problem hiding this comment.
Currently the Queue logic has no limit to the number of items.
You're right though, there should probably be a max, but as this is deprecated code, I'll pass.
| ].join(' ') | ||
| }, | ||
|
|
||
| scrollZoom: { |
There was a problem hiding this comment.
We may apply the changes to this attribute from other PR #3422:
plotly.js/src/plot_api/plot_config.js
Lines 147 to 159 in 16a01e7
There was a problem hiding this comment.
Yes, I'm planning on merging #3422 into this PR.
Make scrollZoom config option a flaglist
|
got a in-person 💃 from @archmoj - merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2703
Unlike #1188, this PR doesn't try to make the config options (or attributes?) compatible with
Lib.coerce. Instead, this PR just listsvalTypeanddescriptionfields for all the config options and formats them into the schema. Here, the default config "object" stays the same, hence there's no breakage in the behaviour.Go to https://22282-45646037-gh.circle-artifacts.com/0/plot-schema.json and
<ctrl-f>for"config":to see the results.cc @plotly/plotly_js