Add support for <sub> and <sup> in "extra" hover label #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that it can selective allow some pseudo-html tags to go through - add truncate logic where allowed pseudo-html tags don't count toward the output "length"
- the malicious <img onerror=""> tag is now gone!
|
Thank you very much! |
etpinard
commented
Jan 17, 2019
src/components/fx/hover.js
Outdated
| } | ||
| name = svgTextUtils.plainText(d.name || '', { | ||
| len: d.nameLength, | ||
| allowedTags: ['br', 'sub', 'sup'] |
There was a problem hiding this comment.
From our list of pseudo-html tags:
plotly.js/src/lib/svg_text_utils.js
Lines 233 to 244 in cc45972
I can us potentially adding <b>, <i> and <em>. Thoughts?
There was a problem hiding this comment.
In webGL texts now we support <b> and <i>. So it might be nice to have them here.
There was a problem hiding this comment.
Ok! Done in -> 6c7b0ed
|
Thanks @etpinard for the improvements 💪 Here's a Codepen showing the fix: https://codepen.io/anon/pen/BMaNox 👌 It's a 💃 for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3357
cc @plotly/plotly_js and @Braintelligence
Note that this PR doesn't fix the alignment problem brought in #3175 (comment) and suspected by @alexcjohnson in #3357 (comment). This issue is now in #3442.