Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Colorscale.crossTraceDefaults to array _module.colorbar definitions #3554

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Feb 19, 2019

fixes #3552 - introduced in #3384

@archmoj could you review this one?

@etpinard etpinard added bug something broken status: reviewable labels Feb 19, 2019
@etpinard
Copy link
Contributor Author

This PR is a quick regression fix. Other limitations exist for multi-colorscale traces, refer to #3555 for that.

@archmoj archmoj self-requested a review February 19, 2019 15:11
@archmoj
Copy link
Contributor

archmoj commented Feb 19, 2019

💃
Thanks @etpinard for the fix.
Should it also be labelled as regression?

@etpinard
Copy link
Contributor Author

Should it also be labelled as regression?

Good 👁️

@etpinard etpinard added regression this used to work and removed bug something broken labels Feb 19, 2019
@etpinard etpinard merged commit bb1239a into master Feb 19, 2019
@etpinard etpinard deleted the scatter3d-colorscale-relink-fixup branch February 19, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression this used to work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter3D errors on modebar interaction
2 participants