Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared color axes #3803

Merged
merged 14 commits into from
Apr 29, 2019
Merged

Shared color axes #3803

merged 14 commits into from
Apr 29, 2019

Commits on Apr 17, 2019

  1. Configuration menu
    Copy the full SHA
    c401f87 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. declare colorbar attrs within Colorscale.attributes()

    - adapt multiple trace attributes.js files accordingly
    - standard colorscale/attributes import to colorScaleAttrs
    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    eb7fe0f View commit details
    Browse the repository at this point in the history
  2. remove obsolete 'line' relinkColorAttrs block

    - 'line' is now declared within _module.colorbar, so
      we don't need this block
    - add scatter3d test for good measure
    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    5e7ed27 View commit details
    Browse the repository at this point in the history
  3. add 'coloraxis' layout attr and default logic

    - reuse Colorscale.supplyDefaults
    - use 'cmin', 'cmax' and 'cauto' no matter the trace types plotted
    - keep track of color axes referenced in the traces in
      fullLayout._colorAxes
    - ignore coloraxis referenced when colorbar visuals are incompatible
    - tweak PlotSchema.get() for layout.colorscale / layout.coloraxis?
      edge cases
    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    ae3f407 View commit details
    Browse the repository at this point in the history
  4. add Colorscale.extractOpts helpers

    ... to help with per-trace min/max/auto or per-coloraxis defs
    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    3e5bec8 View commit details
    Browse the repository at this point in the history
  5. use extractOpts in extractScale

    ... and add makeColorScaleFuncFromTrace wrapper to DRY things up
        a little bit.
    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    8f1fde1 View commit details
    Browse the repository at this point in the history
  6. implement crossTraceDefaults, calc and Colobar.draw for color axes

    - use min of min (and max of max) of all traces linked to same
      color axis to compute min/max when auto:true
    - call Colorscale.crossTraceDefaults after having relinked layout,
      to use coloraxis._min, coloraxis._max
    -
    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    5bb341e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b6503ac View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fa67db3 View commit details
    Browse the repository at this point in the history
  9. add baseline for contour traces w. coloring:heatmap & autocontours:false

    - which has special logic which currently mutates zmin/zmax after
      the calc step.
    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    eab822c View commit details
    Browse the repository at this point in the history
  10. make contour zmin/zmax logic compatible with color axes

    - remove zmin/zmax mutations happening after the calc stpe
    - make traceIs('contour') traces call Colorscale.calc with
      their own options.
    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    bd81ac2 View commit details
    Browse the repository at this point in the history
  11. add shared color axes mocks

    etpinard committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    49103b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2019

  1. Configuration menu
    Copy the full SHA
    1d4d06f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    29a92a6 View commit details
    Browse the repository at this point in the history