Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup noci test - post indicator merge #4014

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jul 3, 2019

  • add indicator mock to svg mock list
  • set _length=null to disable 1D transforms (for now)

following-up on #3978 -- cc @plotly/plotly_js

- add indicator mock to svg mock list
- set _length=null to disable 1D transforms (for now)
@archmoj
Copy link
Contributor

archmoj commented Jul 3, 2019

@etpinard thanks for the fix.
Now noCI jasmine test is passing on my machine.
💃

@etpinard etpinard merged commit d75e956 into master Jul 3, 2019
@etpinard etpinard deleted the indicator-noci-test-fixup branch July 3, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants