Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapbox: add attributions #4069

Merged
merged 8 commits into from
Jul 22, 2019
Merged

mapbox: add attributions #4069

merged 8 commits into from
Jul 22, 2019

Conversation

antoinerg
Copy link
Contributor

@antoinerg antoinerg commented Jul 22, 2019

This PR introduces a sourceattribution attribute to mapbox and displays it on both interactive figures and static images. Because of this, all the baselines had to be updated.

Closes https://github.com/plotly/streambed/issues/13263

@antoinerg
Copy link
Contributor Author

Tests actually passed on CircleCI during the outage: https://circleci.com/workflow-run/89aa9516-2603-437a-96f8-3805f7350d0d

@etpinard etpinard added this to the v1.49.0 milestone Jul 22, 2019
@etpinard
Copy link
Contributor

Awesome work 💃 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants