-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing translation keys #4148
Conversation
@Batalex how well do you know each of the languages you edited? I can personally approve the |
Pinging people that could potentially help us out: @fhurta @JonasGutermuth @n-riesco @booleanbetrayal @Domino987 @ghtmtt @jins-tkomoda @andrefarzat |
@etpinard it has my ok for the pt-br key 😸 |
@etpinard it has my ok for de, but it would be better to be "Graphen herunterladen". Both work though. |
@etpinard +1 for Italian too |
@etpinard cs translation is fine |
Thanks everyone for your time! @Domino987 My german is awful, but how do you feel about the "Download plot as a png" just above? Would "Graphen als PNG herunterladen" be better as well? |
@Batalex yes that would be better as well. |
@etpinard ja translation is also fine! |
@etpinard |
Thanks everyone! We're only missing a 👍 from a |
See #4142
This PR adds the missing "Download plot" localization key for the following languages:
The others languages either have already the missing key or do not translate modebar buttons.
I am by no mean a translator (Deepl/Translate for the win). Native speakers feedbacks are welcome even if it seemed "simple".