Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texttemplate: accept empty text string #4179

Merged
merged 4 commits into from
Sep 10, 2019
Merged

Conversation

antoinerg
Copy link
Contributor

This closes #4173 which affected the following traces:

  • pie
  • funnelarea
  • sunburst

Commit 9b4a38d introduces a test to 🔒 and find all the traces with the bug.

Commit 2e966e0 contains the fix

Codepen before
Codepen after

@archmoj archmoj added status: reviewable bug something broken labels Sep 10, 2019
@archmoj
Copy link
Contributor

archmoj commented Sep 10, 2019

Looking good to me.

@archmoj archmoj removed the bug something broken label Sep 10, 2019
@archmoj
Copy link
Contributor

archmoj commented Sep 10, 2019

@antoinerg Thanks for the quick PR which is going to be helpful for our treemap too.
I would let @etpinard review it & give you a dancer or two : )

@etpinard etpinard added the bug something broken label Sep 10, 2019
@antoinerg
Copy link
Contributor Author

Thanks! Would we mind adding a test for aggregated pie + texttemplate

Done in a4bce50

@etpinard
Copy link
Contributor

Great fix! Thanks 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank text is not placed by texttemplate
3 participants