Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bar transitions: support object constancy #4186

Merged
merged 3 commits into from
Sep 20, 2019
Merged

bar transitions: support object constancy #4186

merged 3 commits into from
Sep 20, 2019

Conversation

antoinerg
Copy link
Contributor

Add support for object constancy to bar transitions!

Codepen

@etpinard
Copy link
Contributor

Awesome!

Next stop: let's try to find a nice way to test this.

@etpinard etpinard added this to the v1.50.0 milestone Sep 11, 2019
@etpinard
Copy link
Contributor

Moreover, can anyone else detect that the text font color transition before the bars' positions are swapped?

@antoinerg
Copy link
Contributor Author

antoinerg commented Sep 11, 2019 •
edited
Loading

Moreover, can anyone else detect that the text font color transition before the bars' positions are swapped?

I confirm that is the case. The reason is that we don't have transitions for text size/color but only for its transform... I could definitely add those in before 1.50.

@etpinard
Copy link
Contributor

The reason is that we don't have transitions for text size/color but only for its transform... I could definitely add those in before 1.50.

Cool. If you don't have the time to add it for 1.50.0, no big deal. Just make sure to add to the TODO list in #3456

@etpinard
Copy link
Contributor

@antoinerg ok to merge?

@antoinerg
Copy link
Contributor Author

@etpinard It looks good to me. I will add text color and font-size tweening in a separate PR

💃

@etpinard etpinard merged commit 59cc28e into master Sep 20, 2019
@etpinard etpinard deleted the bar-obj-constancy branch September 20, 2019 20:44
@nicolaskruchten nicolaskruchten mentioned this pull request Sep 20, 2019
Open
5 tasks
@etpinard
Copy link
Contributor

No problem @antoinerg I updated #3456 accordingly. Thanks!!

@etpinard etpinard mentioned this pull request Sep 30, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
@archmoj archmoj mentioned this pull request Mar 10, 2020
Merged
@etpinard etpinard mentioned this pull request Mar 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
@archmoj archmoj mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature something new
Projects
None yet
Milestone
v1.50.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antoinerg @etpinard