Revise hierarchy referencing and fixup parent percentage at the root node of treemap and sunburst #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- simplify sunburst and treemap percentage references - add hovertemplate tests to treemap - fixup sunburst jasmine texttemplate tests
…here after merging the treemap PR
archmoj
changed the title
etpinard
reviewed
Sep 26, 2019
etpinard
reviewed
Sep 26, 2019
test/jasmine/tests/sunburst_test.js
Outdated
| @@ -1345,7 +1345,7 @@ describe('Test sunburst texttemplate without `values` should work at root level: | |||
| ['path: %{currentPath}', ['path: /', 'path: Eve/', 'path: Eve/', 'path: Eve/', 'path: Eve/', 'path: Eve', 'path: Eve/Seth', 'path: Eve/Seth/', 'path: Eve/Awan/']], | |||
| ['%{percentRoot} of %{root}', ['100% of Eve', '33% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve']], | |||
| ['%{percentEntry} of %{entry}', ['100% of Eve', '33% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve']], | |||
| ['%{percentParent} of %{parent}', ['%{percentParent} of %{parent}', '100% of Seth', '33% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '50% of Seth', '100% of Awan']], | |||
| ['%{percentParent} of %{parent}', ['100% of Eve', '100% of Seth', '33% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '17% of Eve', '50% of Seth', '100% of Awan']], | |||
There was a problem hiding this comment.
Wait. Is this the root node sector? You're saying the parent of the root node is itself?
There was a problem hiding this comment.
Good call. Fixed in 54360be.
There was a problem hiding this comment.
I don't get it. After 54360be, looks like %{parent} is now '', but %{percentParent} is still 100% for the root node.
Can we have '%{percentParent} of %{parent}' resolve as '%{percentParent} of %{parent}' for the root node (i.e. the percentParent and parent keys are not defined) like before?
I know this is not ideal, but I don't like filling in '%{percentParent} and %{parent} with wrong values for the root node just to make the template string look better.
etpinard
reviewed
Sep 26, 2019
archmoj
commented
Sep 30, 2019
|
Nicely done 💃 thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
sunburstandtreemapplotshovertemplateat different levels@etpinard