Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable transforms for image traces #4319

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

etpinard
Copy link
Contributor

fixes this

if(trace.visible !== false && len !== null) {
expect(typeof len).toBe('number', mockSpec[0] + ' trace ' + i + ': type=' + trace.type);
}

@noCI test for our brand-new `image trace type.

cc @archmoj

@etpinard etpinard added bug something broken status: reviewable labels Oct 29, 2019
@archmoj
Copy link
Contributor

archmoj commented Oct 29, 2019

@etpinard thanks very much for the PR.
💃
cc: @antoinerg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants