Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip non-numeric values in image trace plot #4325

Merged
merged 6 commits into from
Nov 1, 2019
Merged

Skip non-numeric values in image trace plot #4325

merged 6 commits into from
Nov 1, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 31, 2019

Fix in respect to @emmanuelle 's comment
#4301 (comment)
i.e. by drawing those pixels with full transparency.

before vs after demo

@alexcjohnson

cc: @nicolaskruchten
cc: @plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Oct 31, 2019
@archmoj archmoj changed the title Skip nun-numeric values in image trace plot Skip non-numeric values in image trace plot Nov 1, 2019
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, love the new mock! 💃

@archmoj archmoj merged commit 50bbb7e into master Nov 1, 2019
@archmoj archmoj deleted the image-nan_ms branch November 1, 2019 13:33
@etpinard
Copy link
Contributor

Nice PR @archmoj - can I why you made some of the colorscale attributes editType: 'calc' now? I suspect this was to make the plot step faster, but I'd like to confirm with you.

@archmoj
Copy link
Contributor Author

archmoj commented Nov 18, 2019

@etpinard Yes. That was for speed and ( if I recall ) not for calling isNumeric during the plot.

@etpinard
Copy link
Contributor

etpinard commented Nov 18, 2019

Yes. That was for speed and ( if I recall ) not for calling isNumeric during the plot.

Yeah, that's very nice. Most colorscale computations for other traces are done during the calc step, so this is fantastic 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants