Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover of mesh3d traces with face color and face intensity #4539

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 31, 2020

Fixes #4527 by displaying facecolor or face-intensity at the center of each face.

demo1 before vs demo1 after

demo2 before vs demo2 after

@plotly/plotly_js
cc: @empet

package.json Outdated
@@ -80,7 +80,7 @@
"gl-heatmap2d": "^1.0.5",
"gl-line3d": "^1.1.11",
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.2.1",
"gl-mesh3d": "git://github.com/gl-vis/gl-mesh3d.git#50a6cb44b02d5837629251cfbd004a3d314a27e7",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard
Copy link
Contributor

Thanks very much! This looks great!! 💃

@etpinard
Copy link
Contributor

(once gl-mesh3d is updated of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mesh3d: false information displayed on hover when hovertemplate gives cell intensities or facecolor
2 participants