Fix download images to match live gl3d plot #4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Feb 10, 2020
| var q = 255 / a; | ||
|
|
||
| for(var l = 0; l < 3; ++l) { // RGB | ||
| pixels[k + l] = Math.min(q * pixels[k + l], 255); |
There was a problem hiding this comment.
Can explain why we need to apply this transform when exporting images?
There was a problem hiding this comment.
Unlike openGL, webGL premultipliedAlpha in enabled by default.
To get correct RGB values from the webgl context it was needed to devide RGB values by alpha.
There was a problem hiding this comment.
Ok, what would happen if we instead disable premultipliedAlpha on image exports?
There was a problem hiding this comment.
Good question; but that didn't work: demo.
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4378 | Demo
@plotly/plotly_js
cc: @alexcjohnson