Ensure text fits inside sunburst sectors with zero values #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Feb 13, 2020
| if(isEmpty) { | ||
| return { | ||
| rCenter: 1 - rInscribed, | ||
| scale: 0, |
There was a problem hiding this comment.
So, by fitting inside text of zero-value sunburst sectors, you mean setting their scale transform to 0, correct?
There was a problem hiding this comment.
The other option (not implemented here) may be not to draw sectors with zero values.
There was a problem hiding this comment.
Or set them with display: 'none', to keep the sector <--> node map 1:1
There was a problem hiding this comment.
... but really, this is fine. It allows us to keep all the logic in transformInsideText.
|
Nicely done 💃 |
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4569 | Demo before vs after
@plotly/plotly_js
cc: @emmanuelle