Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix4631 - handle NaN cases to allow breaks on bar-like traces #4634

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Fix4631 - handle NaN cases to allow breaks on bar-like traces #4634

merged 2 commits into from
Mar 12, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Mar 12, 2020

Fixes #4631.

before
after

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Mar 12, 2020
@archmoj archmoj added this to the v1.53.0 milestone Mar 12, 2020
alexcjohnson
alexcjohnson approved these changes Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that works! 💃

@archmoj archmoj merged commit c5173e1 into master Mar 12, 2020
@archmoj archmoj deleted the fix4631-bar-handle-nan branch March 12, 2020 18:04
@archmoj archmoj mentioned this pull request Mar 12, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken regression this used to work
Projects
None yet
Milestone
v1.53.0
Development

Successfully merging this pull request may close these issues.

Bars with NaNs as positions lead to console errors
2 participants
@archmoj @alexcjohnson