Fix reverse autorange on cartesian axes with breaks #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure account for lBreaks sign - improve and simplify l2p and p2l functions on axis with breaks - reduce extra logic to handle y-axis
etpinard
reviewed
Mar 13, 2020
|
|
||
| if(ax._breaks.length) { | ||
| for(i = 0; i < ax._breaks.length; i++) { | ||
| brk = ax._breaks[i]; | ||
| ax._lBreaks += (brk.max - brk.min); | ||
| ax._lBreaks += brk.max - brk.min; | ||
| } |
There was a problem hiding this comment.
One small recommendation: I think it would be best to keep ax._lBreaks positive-definite. So many below this loop we could have
ax._lBreaks = Math.abs(ax._lBreaks)?
There was a problem hiding this comment.
I tried that at one point. However, allowing negative helped handling reversed cases much easier. For now I added a comment in front of _lBreaks description.
There was a problem hiding this comment.
For now I added a comment in front of
_lBreaksdescription.
That's great!
|
💃 - thanks very much @archmoj long live plotly.js! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up of remaining work #4614 related to
autorange: 'reversed'cases on axes withbreaksas well as some simplification for
l2p&p2lfunctions.@plotly/plotly_js