Fixup parcoords constraintrange valType and validate parcoords mocks #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
force-pushed
the
parcoords-constraintrange-valtype
branch
from
4398996
to
a3274c6
Compare
alexcjohnson
approved these changes
Jul 17, 2021
There was a problem hiding this comment.
OK, this is fine. We could potentially do better if dimensions: '1-2' items with items would validate those items against the each inner array when it's 2D, or the whole array when it's 1D. This seems to be the only place we use dimensions: '1-2', so we can do whatever validation we want. But also, this is a pretty obscure spot (and generally set by GUI, not in code) so really not worth spending much time on.
💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the
constraintrangevalTypeshould be set to "any" instead of "number" so that one could usePlotly.validateoninfo_arraytype with "1-2"dimensions.@plotly/plotly_js