Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cartesian hover toggle #5879

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix cartesian hover toggle #5879

merged 1 commit into from
Jul 13, 2024

Conversation

Sizurka
Copy link
Contributor

@Sizurka Sizurka commented Aug 5, 2021

The hover toggle button couldn't be enabled on cartesian plots because the later setup completely overwrote the initial allowed groups. So just make it add the cartesian buttons instead of replacing the groups completely.

The hover toggle button couldn't be enabled on cartesian plots because
the later setup completely overwrote the initial allowed groups.  So
just make it add the cartesian buttons instead of replacing the groups
completely.
@archmoj archmoj added the community community contribution label Mar 23, 2022
@archmoj
Copy link
Contributor

archmoj commented Mar 23, 2022

@Sizurka Thanks very much for the PR.
Could you please provide a minimal example of illustrating the bug e.g. by forking this codepen?

@Sizurka
Copy link
Contributor Author

Sizurka commented May 3, 2022

See here. Note that there is no hover toggle button on the mode bar, despite it being enabled in the layout. Other buttons (e.x. "togglespikelines") work correctly.

@archmoj archmoj added bug something broken status: has TODOs labels May 6, 2022
@archmoj
Copy link
Contributor

archmoj commented May 6, 2022

Looking good to me.

Please add a test somewhere here:

describe('creates a custom button', function() {

Also I appreciate if you draft 5879_fix.md as described here:
https://github.com/plotly/plotly.js/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Thank you!

@gvwilson gvwilson self-assigned this Jun 10, 2024
@gvwilson
Copy link
Contributor

This pull request has been sitting for a while, so I would like to close it as part of our effort to tidy up our public repositories. I've assigned it to myself to keep track of it; I'll wait until 2024-06-17 for someone to say it's still relevant and they'll to take it on, and otherwise I will close it then. Thanks - @gvwilson

@archmoj
Copy link
Contributor

archmoj commented Jul 13, 2024

Thanks for the fix.
💃
I'l add the draft log after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken community community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants