-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cartesian hover toggle #5879
Conversation
The hover toggle button couldn't be enabled on cartesian plots because the later setup completely overwrote the initial allowed groups. So just make it add the cartesian buttons instead of replacing the groups completely.
@Sizurka Thanks very much for the PR. |
See here. Note that there is no hover toggle button on the mode bar, despite it being enabled in the layout. Other buttons (e.x. "togglespikelines") work correctly. |
Looking good to me. Please add a test somewhere here: plotly.js/test/jasmine/tests/modebar_test.js Line 158 in 042742d
Also I appreciate if you draft Thank you! |
This pull request has been sitting for a while, so I would like to close it as part of our effort to tidy up our public repositories. I've assigned it to myself to keep track of it; I'll wait until 2024-06-17 for someone to say it's still relevant and they'll to take it on, and otherwise I will close it then. Thanks - @gvwilson |
Thanks for the fix. |
Adjust failing modebar test after merging PR #5879
The hover toggle button couldn't be enabled on cartesian plots because the later setup completely overwrote the initial allowed groups. So just make it add the cartesian buttons instead of replacing the groups completely.