griddash

[njwhite]

Resolves #4530 and resolves #4045 : add a griddash property that follows the pattern of gridwidth and gridcolor.

[njwhite]

Hi @archmoj , thanks for the review. I've had a look at why the CI is failing. The 3 baseline diffs are all around text rendering on plots with no gridlines at all - do you know how my PR could be affecting these? Are these tests flakey? Thanks -

[archmoj]

Hi @archmoj , thanks for the review. I've had a look at why the CI is failing. The 3 baseline diffs are all around text rendering on plots with no gridlines at all - do you know how my PR could be affecting these? Are these tests flakey? Thanks -

The tests are flaky. To avoid that please rename your new mocks to start with 'z-' so they don't affect the current rendering order.
Thanks.

[njwhite]

@archmoj thanks, the baseline tests now pass!

[archmoj]

@njwhite Thanks very much for the PR 🏆
It looks like implementing this feature for gl3d subplot requires additional work. So let's skip that in this PR by reverting the changes made to src/plots/gl3d/*.
Then please update the schema to reflect all the changes.
For the image tests, there is a mock named plot_types containing some subplots. Let's try adding a similar one by excluding the gl3d and the pie then add a polar and a smith graph and also add (or modify) a second mock for carpet showing minorgriddash and giddash options please 🙏

[njwhite]

Thanks @archmoj - I've done everything on your list. Some notes:

• The zz00- prefixing looks a bit messy, it might be useful to renumber all the tests in a different PR to fix the ordering
• The tests started failing on this dev branch when master was merged in here. The error is unhelpful (below) and doesn't seem related to the code changes so might be a build infrastructure issue?

 Uncaught Error: Cannot find module '/home/circleci/plotly.js/test/jasmine/tests/animate_test.js'
  Error: Cannot find module '/home/circleci/plotly.js/test/jasmine/tests/animate_test.js'
      at o (/tmp/node_modules/browser-pack/_prelude.js:1:1 <- /tmp/19e1c3e4a7c1296c8a59b89b2cf5cc84.browserify.js:1:167)
      at o (/tmp/node_modules/browser-pack/_prelude.js:1:1 <- /tmp/19e1c3e4a7c1296c8a59b89b2cf5cc84.browserify.js:1:133)
      at test/jasmine/tests/animate_test.js:1:34

Thanks -

[archmoj]

• The tests started failing on this dev branch when master was merged in here. The error is unhelpful (below) and doesn't seem related to the code changes so might be a build infrastructure issue?

 Uncaught Error: Cannot find module '/home/circleci/plotly.js/test/jasmine/tests/animate_test.js'
  Error: Cannot find module '/home/circleci/plotly.js/test/jasmine/tests/animate_test.js'
      at o (/tmp/node_modules/browser-pack/_prelude.js:1:1 <- /tmp/19e1c3e4a7c1296c8a59b89b2cf5cc84.browserify.js:1:167)
      at o (/tmp/node_modules/browser-pack/_prelude.js:1:1 <- /tmp/19e1c3e4a7c1296c8a59b89b2cf5cc84.browserify.js:1:133)
      at test/jasmine/tests/animate_test.js:1:34

There is a memory issue. Please no worry about that one as I could simply rerun the test.

[njwhite]

@archmoj great, I've removed / renamed the mocks -

[njwhite]

@archmoj ok no more gl2d

[archmoj]

💃 💃 💃
💃 💃 💃
💃 💃 💃