Support adding text labels to lines and shapes #6454

emilykl · 2023-01-30T16:30:18Z

Resolves #6430

Adds a label property to Shapes allowing users to define text labels associated with any shape. label property has sub-property text to set the label text and other properties for setting position, styling, angle, etc. Label moves with shape during shape drag and plot drag.

shape.label API

label : Top-level property to be added to shape, holding all label options
- text : The label’s text
- font : The label’s font properties (same properties as for annotation)
  - color
  - family
  - size
- textposition : The label’s position relative to the shape.
  - Possible values for lines: [ start | middle | end ]. Default: middle
  - Possible values for all other shapes: [ top | middle | bottom ] [ left | center | right ]. Default: middle center
- textangle : Rotation angle of the label.
  - Possible values for lines: Number between -180 and 180, or auto (same angle as line). Default: auto
  - Possible values for all other shapes: Number between -180 and 180. Default: 0
- xanchor : The x-component of the anchor point on the label used to determine position (in the pre-rotated reference frame). Possible values : [ auto | left | center | right ]. Default: auto, which has the following behavior — center if position is center, otherwise whatever places the label furthest towards the inside of the shape (e.g. if position is top right, xanchor defaults to right)
- yanchor : The y-component of the anchor point on the label used to determine position (in the pre-rotated reference frame). Possible values : [ top | middle | bottom ]. Default: bottom for lines. middle for all other shapes if position is middle, otherwise whatever places the label furthest towards the inside of the shape (e.g. if position is top right, yanchor defaults to top)
- padding : Offset of label relative to xanchor and yanchor (symmetrical on all sides)
  - x-padding is ignored when xanchor is center
  - y-padding is ignored when yanchor is middle
  - For lines with angle auto: padding is treated as a perpendicular offset from the line

Remaining loose ends (all resolved)

~~Heads up @archmoj @alexcjohnson -- I'll need help tying up these items.~~

~~Label position update during drag does not work when editable=True is set for individual shapes. (It does work when editable=True is set for entire plot.)~~
~~Adding label properties to draw_newshape?~~
~~Some Jasmine tests are timing out -- having a hard time debugging these~~
~~Feedback on image baselines~~
~~General feedback and suggestions~~

Partnership

Development of this feature is sponsored by Volkswagen's Center of Excellence for Battery Systems.

archmoj

Very nice work.
Thanks @emilykl 🏆
Please find my first round comments & suggestions below.

src/components/shapes/attributes.js

archmoj · 2023-01-31T18:05:15Z

src/components/shapes/attributes.js

+                'bottom left', 'bottom center', 'bottom right',
+                'top start', 'top end',
+                'middle start', 'middle end',
+                'bottom start', 'bottom end',


Are these start|end really necessary?
If so, let's describe them in the description please.

Definitely open to suggestions here, but my thought was that corner-based positions like top right, top left etc. don't really make sense for lines because imagine e.g. a downward sloping line -- top right of the bounding box would place the label at a far-off point in space nowhere close to the line.

Even if the line started out sloping upward and so top right made sense, it could be dragged by the user into a downward-sloping position.

I agree that mixing start|end positions with top|middle|bottom is a little convoluted though. One thought I had was that maybe lines should only support 4 specific label positions: top, bottom, start and end (or potentially, top, bottom, left and right). Not sure if that would be more or less confusing.

Maybe @alexcjohnson has thoughts here as well?

My thinking about these attributes is that position refers to a single point on the shape, and [xanchor, yanchor] (plus padding) refers to a single point on the text element, and you position the text so that those two points are in the same place.

So for lines, the only position values that make sense are start|middle|end. We can set smart defaults for xanchor based on those ({start: 'left', middle: 'center', end: 'right'} so that by default for position: start|end the start or end of the text aligns with the start or end of the line, and for position: middle the text is centered on the line. Then yanchor: bottom puts the text on top of the line (ie the bottom of the text is on the line), yanchor: top puts the text under the line, and yanchor: 'middle' puts the text on top of the line. You can get other cool effects then like text preceding the line (position: start, xanchor: right, yanchor: middle) or following the line (position: end, xanchor: left, yanchor: middle)

For other shapes the first nine positions you have are good, and in those cases we can set smart defaults for both xanchor and yanchor to match, ie [xanchorDefault, yanchorDefault] = position.split(' ') so (for rects anyway) by default the text is drawn just inside whatever corner or side you specify with position. Default for all these shapes should be middle center though.

Yeah I think this makes sense @alexcjohnson , thanks!

@alexcjohnson I've implemented these changes to the position property for lines

@alexcjohnson Oh, I realized I skimmed over this part of your comment before:

For other shapes the first nine positions you have are good, and in those cases we can set smart defaults for both xanchor and yanchor to match, ie [xanchorDefault, yanchorDefault] = position.split(' ') so (for rects anyway) by default the text is drawn just inside whatever corner or side you specify with position.

I've implemented the exact opposite -- by default the text is drawn outside the corner, if xanchor and yanchor are not specified. That feels more intuitive to me, and I think it generally looks better, so wanted to verify that that's okay. If it needs to be the other way for consistency with other parts of the API, I can change it.

I guess it depends what we consider the default or most common use case for labels on shapes. I feel like if I was using a shape to label a particular region of a graph - an important x or y range, typically - I'd likely want the label within that region, but off in a corner so it avoids most of the data in that region.

I guess that really only applies to rectangles, for circles or paths being outside the region would be better as otherwise the label would often overlap the edge of the shape, and there are other use cases even for rects where an outside label would make more sense. Perhaps though even then it would make sense for xanchor to be within the bounds and just yanchor to be outside? So for example textposition="top left" would default to xanchor="left", yanchor="bottom"?

Also: can we handle this logic at the defaults stage instead of the draw stage? If we do that, the choices we made show up in fullLayout which can help some users understand and fix unwanted behavior. And at that point I don't see a use for "auto" in these attributes (which in turn means they can probably stop inheriting from annotations)

Oh I guess xanchor on lines with textposition='start'|'end' still needs 'auto' because it depends whether the start is toward the left or right, and we can't know that unless we also know the axis range it's on. That doesn't apply to yanchor though, I still don't see a reason to let that be 'auto'.

But a little more logic around this perhaps, just for lines: If textangle='auto' I would expect the text to be along the line by default, rather than extending off the end. Whereas for any other textangle I'd expect the text to extend off the end, since if it tried to go along the line it would often overlap the line.

@alexcjohnson I've updated xanchor and yanchor defaults so they reflect the following behavior:

yanchor:

Default for lines is bottom

Default for all other shapes is such that the label is positioned inside the shape bounding box (e.g. if textposition is top right, yanchor is top.

auto is not a supported value for yanchor

xanchor default is always auto. This has the following behavior at render:

For lines:

If textangle is auto (parallel to line) xanchor is set so that text is inside the line bounding box

If textangle is anything else, xanchor is set in the opposite direction, so that text is outside the line bounding box

For other shapes: xanchor is set such that the label is positioned inside the shape bounding box (e.g. if textposition is top right, xanchor is right

This mostly works pretty nicely. The only cases that are not ideal are circles and paths -- since the text is positioned inside the bounding box, it overlaps the circle/path in an odd way for any position besides middle center.

We could potentially position the text outside the bounding box by default for circles and paths... but not sure whether that's worth the additional complexity.

archmoj · 2023-01-31T18:09:29Z

src/components/shapes/attributes.js

+        }),
+        position: {
+            valType: 'enumerated',
+            values: [


It looks like we need to have auto dflt and value in respect to src/components/shapes/defaults.js logic.

@archmoj What would be the use case for an auto value for textposition?

@archmoj What would be the use case for an auto value for textposition?

Hmm.. that's a good idea. But as far as I recall we don't have such an option for textposition in other places. So perhaps we could keep this part as is.

src/components/shapes/attributes.js

src/components/shapes/defaults.js

src/components/shapes/draw.js

emilykl · 2023-01-31T23:16:45Z

Thanks so much for the first round review @archmoj !

emilykl · 2023-02-17T18:11:10Z

@alexcjohnson @archmoj A couple dangling property naming questions:

@alexcjohnson Any thoughts on @archmoj 's comment above re: naming the top-level property title rather than label ? I like label better from a usability perspective but happy to change if title makes more sense in the larger scheme of things.
I think position should be renamed to textposition since that property name seems more commonly used across the API (e.g. in plot_schema.json there are 5 properties named position compared to 13 named textposition) -- any objections?

src/components/shapes/attributes.js

src/components/shapes/draw.js

src/components/shapes/draw_newshape/attributes.js

src/components/shapes/draw_newshape/defaults.js

test/image/mocks/zz-text_on_shapes_reversed_axes.json

archmoj · 2023-03-09T18:29:08Z

src/components/shapes/attributes.js

+            description: [
+                'Sets the position of the label text relative to the shape.',
+                'Supported values for rectangles, circles and paths are',
+                '`top left`, `top center`, `top right`, `middle left`,',


Please note that back quotes are used around attribute names not the values.
In all the new documentation, please place values inside * instead.
This line for example would become:

'*top left*, *top center*, *top right*, *middle left*,',

archmoj · 2023-03-09T18:51:52Z

We are almost there.
After updating the descriptions @emilykl please write the draft log for this PR (at draftlogs/6454_add.md) & thank the sponsors possibly with a link to their website.

FYI - These files would be used during the release process to generate the changelog e.g. https://github.com/plotly/plotly.js/releases/tag/v2.17.0

Please see https://github.com/plotly/plotly.js/blob/master/draftlogs/README.md for more info.
Thank you!

archmoj · 2023-03-09T19:38:42Z

@emilykl The PR initial description (#6454 (comment)) looks great! Is it up-to-date too?

archmoj · 2023-03-09T20:02:43Z

---------
|\ |
| 💃 |
| \|
---------

Excellent PR. Thanks @emilykl 🏆 🎖️ 🏅

emilykl · 2023-03-09T20:40:47Z

@archmoj Just updated the PR description!

archmoj · 2023-03-09T22:36:45Z

@emilykl before merging this PR, would you mind pull origin/master & merge master into this branch.
That's to make sure the new lint test we added in #6513 would pass here first.
Thank you!

emilykl requested review from archmoj and alexcjohnson January 30, 2023 16:30

archmoj added feature something new status: reviewable labels Jan 30, 2023

archmoj reviewed Jan 31, 2023

View reviewed changes

emilykl and others added 23 commits February 20, 2023 18:06

add attributes for text on shapes

7ee2e85

draw text, but not in the right place

932fa65

draw text in correct place, when x0 and y0 are defined for shape

1d0e471

update shape label api

e46e1bc

implement xanchor

60823dc

add image test

2f8c810

fix xanchor bug

e405293

partial handling of re-render

e31de9e

handle numeric angles

0bcfff3

handle auto angle for lines, put label drawing code into func

9972dc9

nicer colors on image test

6d5709a

fix weird behavior on pan

072edf6

disable mathjax rendering for shape text

8bee979

clip shape text outside plot area

8528561

fix textangle bug for lines -- angle should always be correct now

b4a4576

correctly handle position prop in most cases

97ee8c4

revert shapes demo to original

674abd8

handle label font

3743de4

redraw text during shape move/resize

c3cc5ed

handle yanchor for text

45a0564

rename mock

b8085c2

handle multiline text and support text on arbitrary paths (sort of)

8c0476e

fix jasmine tests... maybe

95dd9b6

archmoj reviewed Mar 6, 2023

View reviewed changes

src/components/shapes/attributes.js Outdated Show resolved Hide resolved

archmoj reviewed Mar 6, 2023

View reviewed changes

src/components/shapes/draw.js Outdated Show resolved Hide resolved

docstring: specify padding is in px

ffea962

archmoj reviewed Mar 6, 2023

View reviewed changes

src/components/shapes/draw.js Outdated Show resolved Hide resolved

archmoj reviewed Mar 6, 2023

View reviewed changes

src/components/shapes/draw.js Show resolved Hide resolved

archmoj reviewed Mar 6, 2023

View reviewed changes

src/components/shapes/draw_newshape/attributes.js Outdated Show resolved Hide resolved

calculate textangle sin and cos only once

ebe85c4

archmoj reviewed Mar 6, 2023

View reviewed changes

src/components/shapes/draw_newshape/defaults.js Outdated Show resolved Hide resolved

emilykl added 2 commits March 6, 2023 13:20

docstring updates

d113bcf

simplify dfltYanchor implementation

c703c11

archmoj reviewed Mar 8, 2023

View reviewed changes

test/image/mocks/zz-text_on_shapes_reversed_axes.json Show resolved Hide resolved

emilykl and others added 3 commits March 9, 2023 11:02

change temp render logic

468363e

update shape label while editing an editable shape

cdf2d37

test label behavior for draw_newshape

9eb7c90

archmoj reviewed Mar 9, 2023

View reviewed changes

emilykl added 4 commits March 9, 2023 14:13

update docstring formatting

3d2c792

update plot-schema

394555c

add draft log

eaf270d

update draft log

095561f

emilykl added 2 commits March 10, 2023 10:09

Merge branch 'master' into add-text-to-shapes

b0b8ab1

run linter

d927b6a

emilykl merged commit ea8e6d1 into master Mar 10, 2023

emilykl deleted the add-text-to-shapes branch March 10, 2023 16:02

archmoj mentioned this pull request Mar 10, 2023

Adding automargin support to plot titles #6428

Merged

23 tasks

kMutagene added a commit to plotly/Plotly.NET that referenced this pull request Apr 13, 2023

plotly.js v2.19.0: Add label attribute to shapes (plotly/plotly.js#6454)

2f94e87

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support adding text labels to lines and shapes #6454

Support adding text labels to lines and shapes #6454

emilykl commented Jan 30, 2023 •

edited

Loading

archmoj left a comment

archmoj Jan 31, 2023

emilykl Jan 31, 2023 •

edited

Loading

emilykl Jan 31, 2023

alexcjohnson Feb 4, 2023

emilykl Feb 7, 2023

emilykl Feb 17, 2023

emilykl Feb 17, 2023

alexcjohnson Feb 21, 2023

alexcjohnson Feb 21, 2023

emilykl Mar 2, 2023 •

edited

Loading

archmoj Jan 31, 2023

emilykl Mar 2, 2023

archmoj Mar 6, 2023

emilykl commented Jan 31, 2023

emilykl commented Feb 17, 2023

archmoj Mar 9, 2023

archmoj commented Mar 9, 2023

archmoj commented Mar 9, 2023

archmoj commented Mar 9, 2023

emilykl commented Mar 9, 2023

archmoj commented Mar 9, 2023

Support adding text labels to lines and shapes #6454

Support adding text labels to lines and shapes #6454

Conversation

emilykl commented Jan 30, 2023 • edited Loading

shape.label API

Remaining loose ends (all resolved)

Partnership

archmoj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emilykl Jan 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emilykl Mar 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emilykl commented Jan 31, 2023

emilykl commented Feb 17, 2023

Choose a reason for hiding this comment

archmoj commented Mar 9, 2023

archmoj commented Mar 9, 2023

archmoj commented Mar 9, 2023

emilykl commented Mar 9, 2023

archmoj commented Mar 9, 2023

emilykl commented Jan 30, 2023 •

edited

Loading

emilykl Jan 31, 2023 •

edited

Loading

emilykl Mar 2, 2023 •

edited

Loading