Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'Equal Earth' projection #6670

Merged
merged 7 commits into from
Jul 18, 2023

Conversation

apparebit
Copy link
Contributor

@apparebit apparebit commented Jul 10, 2023

Equal Earth is an aesthetically pleasing, fairly recent equal-area pseudocylindrical projection, which has has been adopted by the NASA Goddard Institute for Space Studies. I am submitting this pull request after @alexcjohnson encouraged me to do so in the plotly forum.

[Equal Earth](https://en.wikipedia.org/wiki/Equal_Earth_projection) is an aesthetically pleasing, fairly recent equal-area pseudocylindrical projection, which has has been adopted by the NASA Goddard Institute for Space Studies.
@alexcjohnson
Copy link
Collaborator

Thanks @apparebit ! This looks great, I'll defer to @archmoj (who's on vacation this week) for whether this needs to be included in a test image or a Jasmine test - anyway we'll wait to merge until he's back.

@archmoj the webgl-jasmine tests were particularly flaky here, took 3 retries before they passed. Is this just a bad day at CircleCI or has that test gotten flakier recently?

@archmoj archmoj added feature something new community community contribution status: has TODOs labels Jul 17, 2023
@archmoj
Copy link
Contributor

archmoj commented Jul 17, 2023

Thanks very much for the PR.

Please add examples of using this new projection in the following mocks:

  1. test/image/mocks/various_geo_projections.json
  2. test/image/mocks/geo_fitbounds-locations.json
  3. test/image/mocks/canada_geo_projections.json

Then you could collect & commit new baselines from the ARTIFACTS tab of test-baselines on CircleCi.

draftlogs/6670_add.md Outdated Show resolved Hide resolved
apparebit and others added 4 commits July 17, 2023 12:59
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
I will never look at an Albers USA map the same...
@apparebit
Copy link
Contributor Author

I think I have the mock JSON files figured out by now. I am not a fan of having to manually shift most of the map cells by one position nor of the mocks using Albers USA as a kind of sentinel (surprise!). Having said that, the robotically incrementing numbers mod 8 is long done. I just need CircleCI to provide me with the updated and correct images. After that, the PR should be ready.

Alas, the "webgl-jasmine" tests are incredibly flaky but I cannot do reruns. Even after signing up with CircleCI with my GitHub account, it insists that I need write permissions to the project. Two options:

1 . You can empower me and I'll persist with reruns until the board is green.
2. I have to rely on one of you to do this in my stead.

This is obviously your call. Either works for me. Thank you

@archmoj
Copy link
Contributor

archmoj commented Jul 17, 2023

@apparebit
Copy link
Contributor Author

@archmoj, I think I was committing them while you were writing the comment. The versions I pushed to the branch show Equal Earth and properly shift all subsequent cells including the Albers sentinel.

@archmoj
Copy link
Contributor

archmoj commented Jul 18, 2023

Fantastic. 🎖️ 🏆 💃

@archmoj archmoj merged commit 883ca48 into plotly:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants