Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow default scaleanchor removal #6712

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Allow default scaleanchor removal #6712

merged 5 commits into from
Aug 21, 2023

Conversation

lvlte
Copy link
Contributor

@lvlte lvlte commented Aug 20, 2023

Resolves #6709

@lvlte
Copy link
Contributor Author

lvlte commented Aug 20, 2023

Not sure what is happening with the 'make-baselines' test..

@archmoj
Copy link
Contributor

archmoj commented Aug 21, 2023

Thanks for the PR.
FYI - The baseline tests were now passed.

@archmoj archmoj added feature something new community community contribution status: reviewable labels Aug 21, 2023
@archmoj
Copy link
Contributor

archmoj commented Aug 21, 2023

It's looking very good to me.
If possible, please add draftlogs/6712_add.md file.
Thank you!

alexcjohnson
alexcjohnson approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 very nicely done @lvlte!

@archmoj archmoj merged commit 9a039bd into plotly:master Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
community community contribution feature something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the scaleanchor constrain on axes having an image trace
3 participants
@lvlte @archmoj @alexcjohnson