-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue - column order changes on hover #6718
Fixed issue - column order changes on hover #6718
Conversation
src/plots/plots.js
Outdated
categoriesAggregatedValue.sort(function(a, b) { | ||
return a[1] - b[1]; | ||
}); | ||
categoriesAggregatedValue.sort((a,b) => sortValues(a, b, order)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, so the issue was a mismatch between ax._categoriesAggregatedValue
and ax._initialCategories
?
Performance will be better if we make two functions, sortAscending
and sortDescending
, and pass one or the other to sort
rather than a wrapper function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the issue was a mismatch between ax._categoriesAggregatedValue
and ax._initialCategories
.
I have created two separate functions sortAscending
and sortDescending
.
Could this be merged? |
Nudging again 😄 |
💃 |
Thanks for your interest in plotly.js!
Translations:
lib/locales/
, not those indist/
Features, Bug fixes, and others:
Before opening a pull request, developer should:
master
branch of their fork as usingmaster
for a pull request would make it difficult to fetchupstream
changes.upstream/master
into your fork i.e.origin/master
then pullorigin/master
from you localmaster
.git rebase master
their local dev branch off the latestmaster
which should be sync withupstream/master
at this time.git add
thedist/
folder (thedist/
is updated only on version bumps).package-lock.json
file (if any new dependency required).After opening a pull request, developer:
1010_fix.md
or1010_add.md
insidedraftlogs
folder as described in this README, commit it and push.git push -f
) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please fetchupstream/master
and "merge" with master instead of "rebase".