Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insiderange to cartesian axes #6735

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Add insiderange to cartesian axes #6735

merged 8 commits into from
Oct 19, 2023

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Sep 26, 2023

This feature helps avoid overlap between desired range and inside tick labels of the counter axis.
@plotly/plotly_js

@stephprobst
Copy link

stephprobst commented Sep 26, 2023

Thanks for this PR @archmoj. Looks very good to me. Just a few questions to verify my understanding:

  • If the range attribute is provided, the insiderange attribute will be ignored?
  • The new insiderange attribute will work with the new autorange options (e.g. minallowed)?
  • On a chart with two y-axes. one left and one right, it won't be possible to use the insiderange on the left side and a normal range (overlapping with the labels) on the right side? This is probably not needed, but I just wanted to make sure I understand this correctly and will confirm with my users.

@archmoj
Copy link
Contributor Author

archmoj commented Oct 13, 2023

Thanks for this PR @archmoj. Looks very good to me. Just a few questions to verify my understanding:

  • If the range attribute is provided, the insiderange attribute will be ignored?

When range attribute is provided, the graph has a range and we use that. To declare insiderange, one could provide that and do not provide a range.

@archmoj
Copy link
Contributor Author

archmoj commented Oct 13, 2023

  • The new insiderange attribute will work with the new autorange options (e.g. minallowed)?
    When insiderange is provided. It is used as the default value for range.
    At this point (after 121a664) one have to provide both start and end points in insiderange.
    In future and in a separate PR we may support partial insiderange values (i.e. one end being null and set via autorange options).

@archmoj
Copy link
Contributor Author

archmoj commented Oct 13, 2023

  • On a chart with two y-axes. one left and one right, it won't be possible to use the insiderange on the left side and a normal range (overlapping with the labels) on the right side? This is probably not needed, but I just wanted to make sure I understand this correctly and will confirm with my users.

Not at the moment. It looks like an interesting feature to add.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks great! All the behavior I see around relayout and such behaves just as I'd expect. Nice work 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants