Fix hover count info label in createHoverLabelForColorHovermode
#6944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiweikee
changed the title
totalCount to bandColorCount in createHoverLabelForColorHovermode
weiweikee
changed the title
totalCount to bandColorCount in createHoverLabelForColorHovermodecreateHoverLabelForColorHovermode
archmoj
added
bug
archmoj
reviewed
Mar 28, 2024
|
Thanks very much for the PR. |
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fixes incorrect hover labels in Parallel Categories Diagrams with
'hoveron: color', 'hoverinfo: count'. Labels now accurately reflect counts for the specific color segment hovered over. Below are screenshots of the changes in effect.Before the changes
Hovering on Gray
Hovering on Red
After the changes
Hovering on Gray
Hovering on Red