Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shadow, lineposition and textcase options to SVG fonts #6983

Merged
merged 62 commits into from
May 16, 2024
Merged

Add shadow, lineposition and textcase options to SVG fonts #6983

merged 62 commits into from
May 16, 2024

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 24, 2024 •
edited
Loading

Resolves #6974 also helps address #4674.
Support additional text font styling options based on text-shadow, text-decoration-line & text-transform.

Please see src/plots/font_attributes.js for these new optoins.

@plotly/plotly_js
cc: @ndrezn

archmoj added 30 commits April 23, 2024 21:16
@archmoj
add text-shadow, text-decoration-line & text-transform in drawing.font
5142be6
@archmoj
declare new text font styling attributes
10d5558
@archmoj
implementation
0a1f7a8
@archmoj
adjust toSVG to skip none text style values
1b67344
@archmoj
set auto shadow for sankey, parcats and parcoords that has text-shado…
fe7a30a 
…w before
@archmoj
update sankey, parcats & parcoords baselines - revise contrast src
368cd94
@archmoj
fix shadow attr def
1ce1719
@archmoj
update schema
811ec9a
@archmoj
adjust jasmine tests
614ef31
@archmoj
test axes_custom-ticks_log-date
35bce6c
@archmoj
test axes_labels
c6549e2
@archmoj
test bar_annotation_max_range_eq_category
86dff1b
@archmoj
test bar_attrs_group_norm
3a04219
@archmoj
test bar-colorscale-colorbar
aceb679
@archmoj
test bar_gantt-chart
ab55061
@archmoj
test benchmarks
6e6f04f
@archmoj
test canada_geo_projections
1f8ed20
@archmoj
test cliponaxis_false-dates-log
e8b91ae
@archmoj
test container-legend
e9b2efd
@archmoj
test contour_constraints_equal_boundary_minmax
698b010
@archmoj
test font-variant-bar
faae542
@archmoj
test funnel_axis_textangle_outside
5bd8a2d
@archmoj
test funnel_horizontal_group_basic
628b0aa
@archmoj
test geo_africa-insets
a9479f5
@archmoj
test geo_canadian-cities
625c3c1
@archmoj
test geo_country-names-text-chart
20cace9
@archmoj
test geo_text_chart_arrays
034f446
@archmoj
test geo_text_chart_arrays custom title shadow
1f044fe
@archmoj
test heatmap_brick_padding
0a7e182
@archmoj
test heatmap-text-color-on-missing-data
974a30e
@archmoj
Copy link
Contributor Author

archmoj commented May 10, 2024

This PR is ready for review 🙏

@archmoj archmoj changed the title Add shadow, decorline and capitalize options to SVG fonts Add shadow, decorline and textcase options to SVG fonts May 10, 2024
emilykl
emilykl approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thanks @archmoj !!

@archmoj archmoj requested review from alexcjohnson and gvwilson May 14, 2024 21:23
@archmoj
Copy link
Contributor Author

archmoj commented May 14, 2024

Thanks very much @emilykl for the review and I am also happy with the results at this point.

I would like to have additional approvals before merging.
@gvwilson @alexcjohnson @LiamConnors
Please review the API i.e. new attribute names and options in src/plots/font_attributes.js

Thank you!

gvwilson
gvwilson reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@gvwilson gvwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few small comments on the first few files, but I'm nowhere near understanding this code base well enough to say anything substantial. It looks like an extraordinary amount of work - thank you for wading through it.

src/components/legend/defaults.js Show resolved Hide resolved
src/components/colorbar/defaults.js Show resolved Hide resolved
src/plots/font_attributes.js Show resolved Hide resolved
src/plots/font_attributes.js Show resolved Hide resolved
alexcjohnson
alexcjohnson reviewed May 15, 2024
View reviewed changes
src/snapshot/tosvg.js Outdated Show resolved Hide resolved
@archmoj archmoj changed the title Add shadow, decorline and textcase options to SVG fonts Add shadow, lineposition and textcase options to SVG fonts May 16, 2024
alexcjohnson
alexcjohnson approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks great, this will make a really nice addition!

@archmoj archmoj merged commit c7b1003 into master May 16, 2024
1 check passed
@archmoj archmoj deleted the font-shadow-striding-capitalize branch May 16, 2024 14:08
@alexcjohnson alexcjohnson mentioned this pull request Jun 10, 2024
Closed
@FlorentinTh FlorentinTh mentioned this pull request Jul 17, 2024
Open
@GregBrimble GregBrimble mentioned this pull request Aug 4, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request Aug 9, 2024
Open
@guaiya0507 guaiya0507 mentioned this pull request Aug 9, 2024
Open
This was referenced Sep 29, 2024
Open
Open
@extrafu extrafu mentioned this pull request Oct 2, 2024
Merged
@FlorentinTh FlorentinTh mentioned this pull request Oct 2, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilykl emilykl emilykl approved these changes

@gvwilson gvwilson gvwilson left review comments

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@LiamConnors LiamConnors Awaiting requested review from LiamConnors

Assignees
No one assigned
Labels
feature something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support text-shadow in SVG text
4 participants
@archmoj @emilykl @gvwilson @alexcjohnson