Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where scattergl traces disappear while zooming or panning #7018

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Fix issue where scattergl traces disappear while zooming or panning #7018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79a94da
Limit range before mapping to number
eiriklv Jun 6, 2024
65dcaff
Add draftlog
eiriklv Jun 6, 2024
4b8d0c9
Update draftlogs/7018_fix.md
archmoj Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions draftlogs/7018_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fix displaying scattergl traces while zooming or panning (regression introduced in 2.26.0) [[#7018](https://github.com/plotly/plotly.js/pull/7018)],
with thanks to @eiriklv for the contribution!
7 changes: 2 additions & 5 deletions src/plots/cartesian/dragbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,14 +886,11 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
ya = sp.yaxis;

if(sp._scene) {
var xrng = Lib.simpleMap(xa.range, xa.r2l);
var yrng = Lib.simpleMap(ya.range, ya.r2l);

if(xa.limitRange) xa.limitRange();
if(ya.limitRange) ya.limitRange();

xrng = xa.range;
yrng = ya.range;
var xrng = Lib.simpleMap(xa.range, xa.r2l);
var yrng = Lib.simpleMap(ya.range, ya.r2l);

sp._scene.update({range: [xrng[0], yrng[0], xrng[1], yrng[1]]});
}
Expand Down