Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property ticklabelindex for custom tick label display #7036

Merged
merged 35 commits into from
Jul 10, 2024
Merged

Property ticklabelindex for custom tick label display #7036

merged 35 commits into from
Jul 10, 2024

Commits on Jun 25, 2024

  1. Property drawminorticklabel for drawing the label for each minor ti… 

    …ck n positions away from a major tick

- has no effect for category/multicategory/log axes
- has no effect if tickformat frequency incompatible with minor tick frequency
    @my-tien
    my-tien committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e5725c6 View commit details
    Browse the repository at this point in the history

  2. Ensure correct spacing between ticklabels and ticks when using drawmi… 

    …norticklabel
    @my-tien
    my-tien committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    11fd3f1 View commit details
    Browse the repository at this point in the history

  3. baseline test mock for drawminorticklabel

    @my-tien
    my-tien committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a3e41af View commit details
    Browse the repository at this point in the history

  4. Draftlog for PR 7036 (drawminorticklabel)

    @my-tien
    my-tien committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f7d9abf View commit details
    Browse the repository at this point in the history

  5. "noDrawminorticklabel" exception for gl3d plots

    @my-tien
    my-tien committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1f52f4e View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Fix failing source-syntax check: missing newline in mock

    @my-tien
    my-tien committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    35a7f51 View commit details
    Browse the repository at this point in the history

  2. Restrict drawminorticklabel to period axes

    @my-tien
    my-tien committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    0a80d24 View commit details
    Browse the repository at this point in the history

  3. Revert "Ensure correct spacing between ticklabels and ticks when usin… 

    …g drawminorticklabel"

This reverts commit 11fd3f1.

I thought label overlap with minor ticks was something I introduced with drawminorticklabel, but this was also possible before and is sometimes desired (check e.g. baseline image 24.png)
    @my-tien
    my-tien committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1e7ebc3 View commit details
    Browse the repository at this point in the history

  4. Update mock after restricting new property to period axes

    @my-tien
    my-tien committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    0671ebb View commit details
    Browse the repository at this point in the history

  5. baseline image for zzz_drawminorticklabel_period_axes.png

    @my-tien
    my-tien committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6fcda1a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Refactor periodCompatibleWithTickformat to make behavior clearer.

    @my-tien
    my-tien committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    21a573c View commit details
    Browse the repository at this point in the history

  2. Note about possible future extension of the minor tick label customiz… 

    …ation
    @my-tien
    my-tien committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e511fc8 View commit details
    Browse the repository at this point in the history

  3. Honor ticklabelstep also when using drawminorticklabel

    @my-tien
    my-tien committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7585121 View commit details
    Browse the repository at this point in the history

  4. drawminorticklabel mock for date_axes_period, date_axes_period2, date… 

    …_axes-ticklabelstep
    @my-tien
    my-tien committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e2493a6 View commit details
    Browse the repository at this point in the history

  5. Mention in description that drawminorticklabel only applies to period… 

    … axes
    @my-tien
    my-tien committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    00971f1 View commit details
    Browse the repository at this point in the history

  6. Missing trailing newlines for mocks

    @my-tien
    my-tien committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6f5ba12 View commit details
    Browse the repository at this point in the history

  7. Baseline images for new drawminorticklabel mocks

    @my-tien
    my-tien committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    cd7e7c1 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin-plotly/master' into custom_tick_… 

    …label_display

# Conflicts:
#	src/plots/cartesian/layout_attributes.js
    @my-tien
    my-tien committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ee329a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Rename drawminorticklabel → ticklabelindex

    @my-tien
    my-tien committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0019cb0 View commit details
    Browse the repository at this point in the history

  2. Allow ticklabelindex also for non-period date axes and linear axes. 

    - Also adjust baseline tests to add tests for these.
    @my-tien
    my-tien committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e328c9f View commit details
    Browse the repository at this point in the history

  3. Update ticklabelindex description after allowing linear and date axes.

    @my-tien
    my-tien committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a580821 View commit details
    Browse the repository at this point in the history

  4. Add constant ONEMILLI 

    for enhanced clarity of function `periodCompatibleWithTickformat`
    @my-tien
    my-tien committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    16d792c View commit details
    Browse the repository at this point in the history

  5. Fix missing EOF newline in zzz_date_axes_ticklabelindex.json

    @my-tien
    my-tien committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    82f1fa0 View commit details
    Browse the repository at this point in the history

  6. New and updated baseline images for ticklabelindex mocks

    @my-tien
    my-tien committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    908deec View commit details
    Browse the repository at this point in the history

  7. Satisfy eslint rules

    @my-tien
    my-tien committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    884d975 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Fix ticklabelindex for reversed axes 

    Check for period compatibility did not take reversed axis into account.
Also added reversed axis to mock.
    @my-tien
    my-tien committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6fd6bd4 View commit details
    Browse the repository at this point in the history

  2. Add arrayOk for ticklabelindex, add test case to mock

    @my-tien
    my-tien committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    05d456d View commit details
    Browse the repository at this point in the history

  3. Update baseline image for zzz_ticklabelindex after adding more test c… 

    …ases.
    @my-tien
    my-tien committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d351462 View commit details
    Browse the repository at this point in the history

  4. replace Array.isArray with Lib.isArrayOrTypedArray

    @my-tien
    my-tien committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    96a26da View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Add to ticklabelindex description how it can be useful for period axes

    @my-tien
    my-tien committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    64e14d6 View commit details
    Browse the repository at this point in the history

  2. Mention contributor in draftlog

    @my-tien
    my-tien committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    50b1e0f View commit details
    Browse the repository at this point in the history

  3. refactor calcTicks 

    - improve performance of ticklabelindex initialization
- rename labelTickVals → allTicklabelVals
    @my-tien
    my-tien committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    86b43e4 View commit details
    Browse the repository at this point in the history

  4. refactor calcTicks 

    - use pushUnique
- don't shadow variable name from outer scope
    @my-tien
    my-tien committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0515237 View commit details
    Browse the repository at this point in the history

  5. comment about possible extra values for ticklabelindex

    @my-tien
    my-tien committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b6903e4 View commit details
    Browse the repository at this point in the history

  6. Mention contributor in draftlog for PR 7006

    @my-tien
    my-tien committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f8974e0 View commit details
    Browse the repository at this point in the history