-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node.js v18
and npm v10
in development
#7078
Use node.js v18
and npm v10
in development
#7078
Conversation
2925d31
to
6eaa057
Compare
@archmoj , do you have any idea why the firefox browser won't start in the mathjax-firefox tests? |
I could have a look. Perhaps since those specific versions of firefox are old now they may not be available on new containers or something else. In the meantime, I appreciate it if you could have a second look at #7077 which is blocking the RC including maplibre traces 🙏 |
6eaa057
to
7775810
Compare
@archmoj , it's only the mathjaxfirefox 81/82 that fails after rebasing. Maybe it works with the quotes removed - i don't know because the ci didn't run my last commit. |
I don't see last CircleCI run. |
I made a new commit now here |
OK. There are some errors here: https://app.circleci.com/pipelines/github/plotly/plotly.js?branch=pull%2F7078 |
Karma is still struggling to start the old firefox 81/82 (2020 releases), but the latest start fine. |
6e5dc41
to
17e0058
Compare
@archmoj , I think this is why firefox won't start - some expired key. |
Please resolve the conflicts or open a new PR. |
17e0058
to
8776102
Compare
8776102
to
dc406be
Compare
Please consider updating versions mentioned in https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md#prerequisites as well. |
it's updated now |
There is also Line 62 in e02185f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the PR.
💃
This PR updates to Node 18, which is in maintenance mode until April 30th 2025.
Overview here: https://endoflife.date/nodejs
Closes #7081