-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deprecation warning for mapbox traces and mapbox subplot #7087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for me if the style is consistent with other messages in this repo (not super familiar with its conventions)
Previous deprecation warning example for reference: #5447 |
d5a7463
to
2b51c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like these deprecations will appear in the console if these traces are used... is that correct? I would expect a console warning
A warning is now added in the console when using a |
@emilykl Can I have your review on this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we have the link for the migration docs available, we should include that link directly in this deprecation warning.
@ndrezn Would you please take over this PR? |
@archmoj , I've added the link where the JS migration guide will live (it is not live yet). I believe that |
With the introduction of
scattermap
,choroplethmap
anddensitymap
as well asmap
subplots in #7060 this PR adds deprecation warnings to the description ofscattermapbox
,choroplethmaboxp
anddensitymapbox
as well asmapbox
subplots.@plotly/plotly_js