Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maplibre-gl v4.5.2 #7094

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Bump maplibre-gl v4.5.2 #7094

merged 4 commits into from
Aug 13, 2024

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 13, 2024

@birkskyum Please review the baseline changes.
Thank you!

cc: @plotly/plotly_js s

@birkskyum
Copy link
Contributor

I don't see a diff anywhere.

@archmoj
Copy link
Contributor Author

archmoj commented Aug 13, 2024

There is a slight change there if you use the swipe option.

Screenshot from 2024-08-13 10-36-53

Here is the location of the diff from image comparison test on CircleCI.
diff-map_layers

As well as for diff-map_predefined-styles2 we have:
diff-map_predefined-styles2

@archmoj
Copy link
Contributor Author

archmoj commented Aug 13, 2024

@birkskyum This might be fine.
Just wanted to double check with you if this is alarming in respect to some changes between maplibre-gl versions.

@birkskyum
Copy link
Contributor

birkskyum commented Aug 13, 2024

Hmm, It could be that either the previous or new version didn't manage to load the expected zoom level and used a blurred quarter of a tile from the zoom level above, if it didn't have time enough.

@archmoj
Copy link
Contributor Author

archmoj commented Aug 13, 2024

@birkskyum I'll move forward and merge this PR.
Please feel free to open a PR in case needed.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants