Inline maplibre css from node_modules #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@birkskyum Thanks very much for the PR. |
|
Can you test if a build works, and not just the dev server? |
|
I see some changes to the bundle sizes in https://app.circleci.com/pipelines/github/plotly/plotly.js/11270/workflows/422af31b-c7fb-49f7-b06b-5e5c51081ea2/jobs/249307/parallel-runs/0/steps/0-108 But please double check. Perhaps you may try using the basic partial build from the CircleCI artifatcs in a codepen like this? |
gvwilson
added
community
|
@birkskyum please add a draft log. |
archmoj
reviewed
Sep 6, 2024
7 tasks
|
i believe it's working now - i see the ~66kb ( size of the .css ) added to the bundle. |
|
Nicely revised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the css from node_modules instead of unpkg. Mapbox traces inline the css, and doing so for maplibre as well will allow the map_ traces to run fully offline, ofc. at the cost of some bundle size.
Fixes #7139
This works for the dev server
npm run start, but it might not yet get the .css inline in the build.