Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for deprecated bardir attribute (use orientation instead) #7214

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Drop support for deprecated bardir attribute (use orientation instead) #7214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1acf90d
remove deprecated 'bardir' attribute (replaced by 'orientation')
emilykl Oct 7, 2024
f428565
update plot-schema
emilykl Oct 7, 2024
093ae80
add draftlog
emilykl Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/7214_remove.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Drop support for deprecated `bardir` attribute (use `orientation` instead) [[#7214](https://github.com/plotly/plotly.js/pull/7214)]
11 changes: 0 additions & 11 deletions src/plot_api/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,17 +295,6 @@ exports.cleanData = function(data) {
delete trace.error_y.opacity;
}

// convert bardir to orientation, and put the data into
// the axes it's eventually going to be used with
if('bardir' in trace) {
if(trace.bardir === 'h' && (traceIs(trace, 'bar') ||
trace.type.substr(0, 9) === 'histogram')) {
trace.orientation = 'h';
exports.swapXYData(trace);
}
delete trace.bardir;
}

// now we have only one 1D histogram type, and whether
// it uses x or y data depends on trace.orientation
if(trace.type === 'histogramy') exports.swapXYData(trace);
Expand Down
9 changes: 0 additions & 9 deletions src/traces/bar/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,4 @@ module.exports = {
editType: 'style'
},
zorder: scatterAttrs.zorder,

_deprecated: {
bardir: {
valType: 'enumerated',
editType: 'calc',
values: ['v', 'h'],
description: 'Renamed to `orientation`.'
}
}
};
4 changes: 0 additions & 4 deletions src/traces/histogram/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,5 @@ module.exports = {
selected: barAttrs.selected,
unselected: barAttrs.unselected,

_deprecated: {
bardir: barAttrs._deprecated.bardir
},

zorder: barAttrs.zorder
};
22 changes: 0 additions & 22 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17291,17 +17291,6 @@
"bar": {
"animatable": true,
"attributes": {
"_deprecated": {
"bardir": {
"description": "Renamed to `orientation`.",
"editType": "calc",
"valType": "enumerated",
"values": [
"v",
"h"
]
}
},
"alignmentgroup": {
"description": "Set several traces linked to the same position axis or matching axes to the same alignmentgroup. This controls whether bars compute their positional range dependently or independently.",
"dflt": "",
Expand Down Expand Up @@ -43700,17 +43689,6 @@
"histogram": {
"animatable": false,
"attributes": {
"_deprecated": {
"bardir": {
"description": "Renamed to `orientation`.",
"editType": "calc",
"valType": "enumerated",
"values": [
"v",
"h"
]
}
},
"alignmentgroup": {
"description": "Set several traces linked to the same position axis or matching axes to the same alignmentgroup. This controls whether bars compute their positional range dependently or independently.",
"dflt": "",
Expand Down