better tests

plotly · Jul 21, 2021 · 1e24ca0 · 1e24ca0
1 parent 458554a
commit 1e24ca0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/python/plotly/plotly/io/_base_renderers.py b/packages/python/plotly/plotly/io/_base_renderers.py
@@ -679,6 +679,8 @@ def open_html_in_browser(html, using=None, new=0, autoraise=True):
         for browser_key in using:
             try:
                 browser = webbrowser.get(browser_key)
+                if browser is not None:
+                    break
             except webbrowser.Error:
                 pass
 

diff --git a/packages/python/plotly/plotly/tests/test_io/test_renderers.py b/packages/python/plotly/plotly/tests/test_io/test_renderers.py
@@ -226,9 +226,8 @@ def test_browser_renderer_show(fig1, renderer):
     pio.renderers.default = renderer
     renderer_obj = pio.renderers[renderer]
     using = renderer_obj.using
-    if isinstance(renderer_obj.using, tuple):
-        using = renderer_obj.using[0]
-        renderer_obj.using = using
+    if not isinstance(renderer_obj.using, tuple):
+        using = (using,)
 
     # Setup mocks
     mock_get = MagicMock(name="test get")
@@ -253,7 +252,7 @@ def open_url(url, new=0, autoraise=True):
         pio.show(fig1)
 
     # check get args
-    mock_get.assert_called_once_with(using)
+    mock_get.assert_any_call(using[0])
 
     # check open args
     mock_call_args = mock_browser.open.call_args