-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plotlywidget 1.5.3 fails to render FigureWidget in JupyterLab 2.x #2249
Comments
Note that Ideally we would find a backwards-compatible change, or we'll have to do the awkward documentation thing where we say "JupyterLab 1.2 needs this and JupyterLab 2.0 needs that" :( |
If I would had been more observant, my initial PR to support JupyterLab 2.0.0 would have also made the plotlywidget extension support it in the same sense as for the plotly-extension. I would do it by ensuring its dependencies were specified to allow for both use of JupyterLab 1 and 2 dependencies, which it use in a non-breaking way as far as I understand.
Dear rubber duck of understanding...I've learned that jupyter-widgets/base 2 is requested by plotly-extension and @jupyter-widgets/jupyterlab-manager, and installing it for JupyterLab 2 requires a lot of JupyterLab 2 dependencies. Hmmm... I really struggle to grasp all this, but, what I know is, that I think it would make sense to do the PR, as that allow it to install with the available JupyterLab 2 dependencies and not specifically JupyterLab 1 dependencies. I think... |
@nicolaskruchten thanks for your work on this project ❤️! This issue should be closed now 🎉! |
Thanks for the reminder, and for your work on helping us keep up with the world of JupyterLab :) |
Although #2245 allowed us to install the extensions into JupyterLab, it looks like the
FigureWidget
is currently broken in JupyterLab 2.xThe text was updated successfully, but these errors were encountered: