-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JupyterLab 2.0.0 #2245
Support JupyterLab 2.0.0 #2245
Conversation
Thanks very much for this PR! I'll QA it today and if all looks good, release as well. This is intended to be backwards-compatible in the sense that the extension should run in JupyterLab 1.2 as well, correct? |
@nicolaskruchten you'r welcome =) Yes exactly, this jupyterlab extension it will installable with both JupyterLab 1 and 2. If we would remove the I opted to have a |
@nicolaskruchten I bumped the node package version of this npm package itself, I'm not sure if that made sense to do. |
Super, thanks for the clarifications. Bumping the package version is fine I think: normally I do it during the release process but I'll likely merge and release within a few minutes anyway so this is great :) |
OK this all looks awesome, I should be able to merge and release tonight after the kids are in bed (famous last words!) I should add that it's always a real pleasure to head to work thinking "man, gotta deal with this new problem that cropped up" and to arrive to find a PR that fixes it, ready to go, so thanks again! |
This is now released! Unfortunately |
I think this is a backward compatible change that makes the jupyterlab extension
jupyterlab-plotly
support JupyterLab 2.0.0 by accepting also JupyterLab 2.0.0 required dependencies.Fixes #2244
JupyterLab 2.0.0 references