Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JupyterLab 2.0.0 #2245

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Support JupyterLab 2.0.0 #2245

merged 2 commits into from
Mar 6, 2020

Conversation

consideRatio
Copy link
Contributor

I think this is a backward compatible change that makes the jupyterlab extension jupyterlab-plotly support JupyterLab 2.0.0 by accepting also JupyterLab 2.0.0 required dependencies.

Fixes #2244

JupyterLab 2.0.0 references

@nicolaskruchten
Copy link
Contributor

Thanks very much for this PR! I'll QA it today and if all looks good, release as well.

This is intended to be backwards-compatible in the sense that the extension should run in JupyterLab 1.2 as well, correct?

@consideRatio
Copy link
Contributor Author

consideRatio commented Mar 5, 2020

@nicolaskruchten you'r welcome =) Yes exactly, this jupyterlab extension it will installable with both JupyterLab 1 and 2. If we would remove the || parts in the package.json and only use the newer version, it would disrupt JupyterLab 1 users wanting to use the latest released version of the plotly-extension, as they would instead get the latest compatible version which would be those before this PR assuming it removed the || part.

I opted to have a || part to make JupyterLab 1 and 2 usable with any future releases of this extension and not only JupyterLab 2, as there will be various JupyterLab 1 users straggling that may want to use the latest releases coming seemingly quite often for the plotly-extension.

@consideRatio
Copy link
Contributor Author

@nicolaskruchten I bumped the node package version of this npm package itself, I'm not sure if that made sense to do.

@nicolaskruchten
Copy link
Contributor

Super, thanks for the clarifications. Bumping the package version is fine I think: normally I do it during the release process but I'll likely merge and release within a few minutes anyway so this is great :)

@nicolaskruchten nicolaskruchten self-requested a review March 5, 2020 19:26
@nicolaskruchten
Copy link
Contributor

OK this all looks awesome, I should be able to merge and release tonight after the kids are in bed (famous last words!)

I should add that it's always a real pleasure to head to work thinking "man, gotta deal with this new problem that cropped up" and to arrive to find a PR that fixes it, ready to go, so thanks again!

@nicolaskruchten
Copy link
Contributor

This is now released! Unfortunately FigureWidgets don't appear to work in JLab 2.x... See #2249 for details if you're curious or have any ideas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using plotly with jupyterlab 2.0
2 participants