Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-doc workflow fails on CircleCI #3702

Closed
maresb opened this issue May 1, 2022 · 2 comments
Closed

build-doc workflow fails on CircleCI #3702

maresb opened this issue May 1, 2022 · 2 comments

Comments

@maresb
Copy link
Contributor

maresb commented May 1, 2022

Looking at the checks for all the recent PRs, they are failing on the "make html" step with

ImportError: cannot import name 'contextfilter' from 'jinja2'

This seems to be a problem with a breaking change since jinja2 v3.1. Since the nbconvert version is currently pinned to the old v5.6.1 the version constraints of nbconvert don't account for the change to jinja2.

I can see three obvious potential ways to solve this:

  1. Pin jinja2<3.1
  2. Unpin nbconvert=5.6.1
  3. Use some tool to lock dependencies to guarantee reproducible builds

At least one of 1. or 2. will probably lead to a quick fix, but will inevitably lead to similar eventual future breakage. So 3. is probably the better solution, but requires significantly more effort.

Reference: nbconvert issue regarding ImportError

maresb added a commit to maresb/plotly.py that referenced this issue May 1, 2022
maresb added a commit to maresb/plotly.py that referenced this issue May 1, 2022
@nicolaskruchten
Copy link
Contributor

Thanks! I'm not sure why the jobs are not running on your PRs but the path of least resistance here is to pin jinja I think.

@nicolaskruchten
Copy link
Contributor

Closed by #3704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants