Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed a missing comma in updated configkeys #1065

Merged
merged 2 commits into from
Jul 21, 2018
Merged

fixed a missing comma in updated configkeys #1065

merged 2 commits into from
Jul 21, 2018

Conversation

michaelbabyn
Copy link
Contributor

No description provided.

jonmmease
jonmmease suggested changes Jul 21, 2018
View reviewed changes
Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like we also need commas after
'staticPlot', 'queueLength', 'topojsonURL'

Could you add these too?

@jonmmease jonmmease added this to the v3.1.1 milestone Jul 21, 2018
@michaelbabyn
Copy link
Contributor Author

Ha! it's done :)

@jonmmease jonmmease merged commit 2383969 into plotly:master Jul 21, 2018
@jonmmease
Copy link
Contributor

Thanks @michaelbabyn!

@michaelbabyn michaelbabyn deleted the missing_comma_config_keys branch July 21, 2018 12:09
@jonmmease jonmmease mentioned this pull request Sep 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmmease jonmmease jonmmease requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbabyn @jonmmease