Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stream write validation to avoid incorrect validation failures #1145

Merged
merged 2 commits into from
Sep 1, 2018

Conversation

jonmmease
Copy link
Contributor

@jonmmease jonmmease commented Aug 31, 2018

Fix for #1108

Removed validation since stream writes don't actually have the same validation rules as traces.

cc @gnthibault

Removed validation since stream writes don't actually have the same
validation rules as traces.
@jonmmease jonmmease requested a review from Kully August 31, 2018 11:40
@jonmmease
Copy link
Contributor Author

@Kully , I'm going to go ahead and merge this so it's on master for testing over the next few days. Please still take a glance if you have a chance over the next couple of days.

@Kully
Copy link
Contributor

Kully commented Sep 3, 2018

@jonmmease fantastic! It's working now.

One note is that setting x and y to an array doesn't append any data to the figure but instead updates the chart to the most recent x=[...], y=[...] you are writing to it. But setting x=5, y=2 now appends to the figure and updates the chart just fine.

So yeah, removing the validation seems to be bypassing the issues we were having before. Are you now trying to write a validation for streaming that isn't broken?

@jonmmease
Copy link
Contributor Author

The behavior of appending with a scalar and overwriting with a list is consistent with the pre 3.0 behavior. That's really handled by plot.ly not plotly.py.

I don't have any particular plans for adding validation back, or for the streaming API in general. But if someone else is interested in improving this side if things that would be fine with me.

@nicolaskruchten nicolaskruchten deleted the bug_1108 branch June 19, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants