Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaScript "Error: addFrames failure" in offline html export #1152

Merged
merged 2 commits into from
Sep 2, 2018

Conversation

jonmmease
Copy link
Contributor

Fix for "Problem 3" in #1147.

Since version 3.0, stand-alone html files/divs generated by plotly.offline.plot resulted in a harmless JavaScript error on load if no Frames were defined.

Uncaught (in promise) Error: addFrames failure: frameList must be an Array of frame definitions[object Object]
    at Object.r.addFrames (pca:73)
    at pca:79

The problem was that the no-frames case was being represented by an empty dict rather than an empty list. Also, the frames logic should not have been output at all for the empty frames case.

cc: @CiaranWelsh

@jonmmease jonmmease merged commit 07a2ab3 into master Sep 2, 2018
@nicolaskruchten nicolaskruchten deleted the bug_1147a branch June 19, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant