Pandas datetime and numpy numeric array fixes #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Preserve numeric numpy types as is in validator out, even if that
numeric type is not supported as JavaScript TypedArray
2) Update widget serializer to check numeric numpy arrays for whether
they are compatible with TypedArrays. If not, serialize as list.
3) Call to_pydatetime() on pandas datetime series/index values
when passed to copy_to_readonly_numpy_array. This returns numpy
array of datetimes (which we already know how to serialize)
Fixes datetime issue in #1160
Fixes FigureWidget issue in #1155
[skip ci]
This was referenced Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numeric type is not supported as JavaScript TypedArray.
they are compatible with
TypedArrays. If not, serialize as list.to_pydatetime()on pandas datetime series/index valueswhen passed to
copy_to_readonly_numpy_array. This returns numpyarray of datetimes (which we already know how to serialize)
_plotly_utils/tests/validators/test_pandas_series_input.pytest suiteFixes datetime issue in #1160 (cc @VelizarVESSELINOV)
Fixes FigureWidget issue in #1155