-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow forcing a fix axis scale ratio to maintain arrow lengths #1197
Conversation
…ixed in layout and is =1 in the Quiver object.
0b11a50
to
ee40b82
Compare
Hi @dabana, I haven't reviewed/tested this in detail yet but at a high level this looks great! In the meantime, could you add a simple test to Thanks for the great contribution! |
It will be done. |
There were no test class for the quiver plot, so I created it. But when trying out the tests with Nose:
I get the following import error:
even though the |
0fb326c
to
04dc529
Compare
Thanks @dabana, this looks great! Thanks for the test, docstring, and example. I tried out several other examples and this makes the interpretation of the arrow lengths much more accurate. Also, let me know if there's anything else you're interested in doing to improve |
Great! This PR is a good first step toward issue #1187. I would like to make the choice of |
Addresses issue #1187.
A new
scaleratio
parameter is added to thecreate_quiver
function to allow forcing a fix scale ratio to the axis of the plot through thescaleratio
option in the Layout. A distortion is introduced to the arrows length, angle and shape by having a scale ratio different than 1. In this pull request, this distortion is reversed by multiplying or dividing byscaleratio
at key steps of the arrows construction.