Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2D arrays in InfoArrayValidator #1240

Merged
merged 5 commits into from
Oct 23, 2018
Merged

Conversation

jonmmease
Copy link
Contributor

@jonmmease jonmmease commented Oct 23, 2018

Supersedes #1233, which didn't recover from the GitHub outage:


Rework InfoArrayValidator to fix #1220

@jonmmease jonmmease changed the title Bug 1220 take2 Add support for 2D arrays in InfoArrayValidator Oct 23, 2018
@jonmmease jonmmease merged commit 4c054a3 into master Oct 23, 2018
@saebaxp
Copy link

saebaxp commented Nov 6, 2018

This line in InfoArrayValidator.validate_coerce() doesn't look like right:
is_v_2d = v and is_array(v[0])
for methods like 'animate' expecting their 'args' containing a first argument as a list of frame names (but it's not a really 2d array as a whole, I believe), above code gives an unexpected error.

Changing it to:
is_v_2d = v and all([is_array(vv) for vv in v])
corrected the issue.

Could you please give a look?

@jonmmease
Copy link
Contributor Author

That's a good point @saebaxp, I've opened #1265 to track this

@saebaxp
Copy link

saebaxp commented Nov 7, 2018

Thanks for the quick turnaround! @jonmmease

@nicolaskruchten nicolaskruchten deleted the bug_1220_take2 branch June 19, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Validation Error for layout.grid.subplots attribute
2 participants