Pass config object to iplot when rendering plotly JSON #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gnestor, @bpostlethwaite @charleyferrari I'll test this out for regressions. Could you look it over and try it out against an on-prem instance? |
|
We will thanks @jonmmease ! |
|
👍 This is working for me with buildly! |
|
Looks good, thanks @gnestor |
michaelbabyn
pushed a commit
to michaelbabyn/plotly.py
that referenced
this pull request
Dec 22, 2018
* Pass config object to iplot when rendering plotly JSON * Pass config file contents by default * Pass plotly_domain as plotlyServerURL to front-end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where users render a Plotly chart to a Jupyter Notebook or JupyterLab (using Plotly JSON and @jupyterlab/plotly-extension vs.
plotly.offline.init_notebook_mode) but they're custom Plotly config is not passed to plotly.js (e.g.plotly_domainandplotly_streaming_domain).Demo notebook: