Update config options and disable show_link by default #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raise a warning for options that are not known by plotly.py to be valid Previously we would silently drop unrecognized options. This change was done so that if plotly.py falls behind plotly.js in the future, the user still has a way to specify all config options supported by plotly.js
Along with the change to set `showSendToCloud` to False by default in plotly.js 1.43.0, now the default behavior of plotly.py/plotly.js is that there are no options available by default that will send data off of the local network.
This test was running into a bug in unittest (https://bugs.python.org/issue29620). Revisit this when we move to pytest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1290 and #1304.
'responsive','showSendToCloud', and'watermark'.show_linkoption has been set toFalseby default in the offlineplotandiplotfunctions. Now that the "send data to cloud" button has been disabled by default in plotly.js 1.43.0, no buttons/links will be displayed by default that result in data being sent off of the local machine.